[PATCH] D90249: Add options to enable memoryssa for loopsink, expand loopsink testing and fix exposed bug in LICM

Jamie Schmeiser via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 3 09:35:57 PST 2020


jamieschmeiser updated this revision to Diff 302605.
jamieschmeiser retitled this revision from "enable memoryssa for loopsink in new passmanager, expand loopsink testing and fix exposed bug in LICM" to "Add options to enable memoryssa for loopsink, expand loopsink testing and fix exposed bug in LICM".
jamieschmeiser edited the summary of this revision.
jamieschmeiser added a comment.

Respond to review comments by adding options controlling whether
memoryssa is used for loopsink, defaulting to false.  Expanded the
tests to include these options.

Note that the tests for passes are still changed because the dependency
on memory ssa is required in order to allow the option of using
memory ssa in the legacy pass manager.  If my understanding of this
is incorrect, please let me know and I will remove the dependency
and the changes to the passes tests.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90249/new/

https://reviews.llvm.org/D90249

Files:
  llvm/lib/Transforms/Scalar/LICM.cpp
  llvm/lib/Transforms/Scalar/LoopSink.cpp
  llvm/test/CodeGen/AMDGPU/opt-pipeline.ll
  llvm/test/Other/opt-O2-pipeline.ll
  llvm/test/Other/opt-O3-pipeline-enable-matrix.ll
  llvm/test/Other/opt-O3-pipeline.ll
  llvm/test/Other/opt-Os-pipeline.ll
  llvm/test/Transforms/LICM/loopsink-pr38462.ll
  llvm/test/Transforms/LICM/loopsink-pr39570.ll
  llvm/test/Transforms/LICM/loopsink-pr39695.ll
  llvm/test/Transforms/LICM/loopsink.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D90249.302605.patch
Type: text/x-patch
Size: 18717 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201103/e8d25811/attachment.bin>


More information about the llvm-commits mailing list