[PATCH] D90690: added test & fixed broken "add more than one section" workflow in objcopy on MachO Binaries.

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added a comment.

Mechanical note: we try to keep the first line of the commit message concise (preferably under 72 characters; some people try to keep it under 50 <https://preslav.me/2015/02/21/what-s-with-the-50-72-rule/>). We also usually add tags in square brackets to indicate the areas the patch touches. A conventional subject line for this commit would be something like:

  [llvm-objcopy][MachO] Fix adding multiple sections



================
Comment at: llvm/test/tools/llvm-objcopy/MachO/add-multiple-sections.test:1
+## This test verifies that llvm-objcopy can add multiple sections to a Mach-O binary.
+
----------------
I'd also add a test for adding two new sections into two different segments.

There's a couple of more tests for `--add-section` that would be good to have, but fall outside the scope of this diff (they're better suited for `add-section-error.test`). I'm also note sure what the desired behavior for them is (maybe @alexshap would know):
* Issuing multiple `--add-section` commands with the same section name.
* Attempting to add a section with the same name and segment as an existing section.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90690/new/

https://reviews.llvm.org/D90690