[PATCH] D90690: added test & fixed broken "add more than one section" workflow in objcopy on MachO Binaries.

Cornelius Aschermann via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 3 08:46:13 PST 2020


eqv created this revision.
Herald added a reviewer: alexshap.
Herald added a reviewer: rupprecht.
Herald added a reviewer: jhenderson.
Herald added subscribers: llvm-commits, pengfei, abrachet.
Herald added a project: LLVM.
eqv requested review of this revision.
Herald added a subscriber: MaskRay.

Added a test for the broken behavior and fixed size field in newly added sections.

Test Plan:

in
cd ~/local/toolchain_dev/build/Release/Linux-x86_64/toolchain # run:
ninja check-llvm-tools-llvm-objcopy # run all tests for objcopy
ninja check-llvm # run all LLVM tests ... it's good practice


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D90690

Files:
  llvm/test/tools/llvm-objcopy/MachO/add-multiple-sections.test
  llvm/tools/llvm-objcopy/MachO/MachOObjcopy.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D90690.302596.patch
Type: text/x-patch
Size: 4861 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201103/39b98a81/attachment.bin>


More information about the llvm-commits mailing list