[PATCH] D90692: [ARM] remove cost-kind predicate for math op costs

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 3 10:03:20 PST 2020


dmgreen added a comment.

The MVECostFactor should probably be 1 for codesize. I'm not 100% sure on Neon code, FunctionCallDivCost looks dubious, but I'm more worried about the MVE costs.

I was surprised to see this effect so much. I had it in my head that more things were using Recip costing.



================
Comment at: llvm/lib/Target/ARM/ARMTargetTransformInfo.cpp:1247
   int BaseCost = ST->hasMVEIntegerOps() && Ty->isVectorTy()
                      ? ST->getMVEVectorCostFactor()
                      : 1;
----------------
Can you change this to 1 under size.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90692/new/

https://reviews.llvm.org/D90692



More information about the llvm-commits mailing list