[PATCH] D90692: [ARM] remove cost-kind predicate for math op costs

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 3 09:09:45 PST 2020


spatel created this revision.
spatel added reviewers: samparker, dmgreen, efriedma.
Herald added subscribers: danielkiss, pengfei, hiraditya, kristof.beyls, mcrosier.
Herald added a project: LLVM.
spatel requested review of this revision.

I'm not sure if this matches the suggestion from D90554 <https://reviews.llvm.org/D90554>, but it's based on the same idea that I am using for the basic model implementation and what I have partly already done for x86: throughput cost is number of instructions/uops, so size/blended costs are identical except in special cases (for example, fdiv or other always-known-expensive machine instructions).

That said, I have no clue about the accuracy of the ARM subtarget variations seen in the cost tests or whether the functional diffs are good or bad.


https://reviews.llvm.org/D90692

Files:
  llvm/lib/Target/ARM/ARMTargetTransformInfo.cpp
  llvm/test/Analysis/CostModel/ARM/arith.ll
  llvm/test/Analysis/CostModel/ARM/intrinsic-cost-kinds.ll
  llvm/test/Analysis/CostModel/ARM/reduce-add.ll
  llvm/test/CodeGen/Thumb2/LowOverheadLoops/reductions.ll
  llvm/test/Transforms/SimplifyCFG/ARM/phi-eliminate.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D90692.302602.patch
Type: text/x-patch
Size: 55510 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201103/15b46930/attachment.bin>


More information about the llvm-commits mailing list