[PATCH] D71302: [llvm-ar] Improve tool selection logic

[Nico Weber via Phabricator via llvm-commits]

thakis added inline comments.


================
Comment at: llvm/test/tools/llvm-dlltool/tool-name.test:5
+# RUN: rm -rf %t
+# RUN: mkdir %t
+# RUN: ln -s llvm-dlltool %t/dlltool.exe
----------------
thakis wrote:
> thakis wrote:
> > FYI, this test never ran because llvm/test/tools/llvm-dlltool/lit.local.cfg has `config.suffixes = ['.def']` (instead of `config.suffixes.add('.def')`). (And if I change the lit.local.cfg file to make it run, the test fails.)
> fixed in af9bf14e6b0
(maybe lit should diag if there are files in a dir that contains RUN lines but that are skipped because of config.suffixes?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71302/new/

https://reviews.llvm.org/D71302