[PATCH] D71302: [llvm-ar] Improve tool selection logic

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 3 08:59:40 PST 2020


thakis added inline comments.


================
Comment at: llvm/test/tools/llvm-dlltool/tool-name.test:5
+# RUN: rm -rf %t
+# RUN: mkdir %t
+# RUN: ln -s llvm-dlltool %t/dlltool.exe
----------------
thakis wrote:
> FYI, this test never ran because llvm/test/tools/llvm-dlltool/lit.local.cfg has `config.suffixes = ['.def']` (instead of `config.suffixes.add('.def')`). (And if I change the lit.local.cfg file to make it run, the test fails.)
fixed in af9bf14e6b0


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71302/new/

https://reviews.llvm.org/D71302



More information about the llvm-commits mailing list