[PATCH] D90538: [Flang][OpenMP] Fix 'Internal: no symbol found' for OpenMP aligned and linear clause.

[Valentin Clement via Phabricator via llvm-commits]

clementval added inline comments.


================
Comment at: flang/lib/Semantics/resolve-directives.cpp:288
+    }
+    return true;
+  }
----------------
kiranchandramohan wrote:
> sameeranjoshi wrote:
> > kiranchandramohan wrote:
> > > Can this be false here?
> > Keeping it for consistency sake with the convention followed in the file.
> > Just asking if you know is there some reason to use some specific boolean value?
> See the following links for the general answer. Basically the walk wont proceed to the nested components and will not call Post if false is returned.
> 
> https://github.com/llvm/llvm-project/blob/32897c05ab6ba90c3496270046aa5664b37f6557/flang/include/flang/Parser/parse-tree-visitor.h#L23
> 
> https://github.com/llvm/llvm-project/blob/32897c05ab6ba90c3496270046aa5664b37f6557/flang/include/flang/Parser/parse-tree-visitor.h#L178
If you raise an error here you might want to return false to not go further in the visit since you might not have the information to continue in the nested nodes. 




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90538/new/

https://reviews.llvm.org/D90538