[PATCH] D90538: [Flang][OpenMP] Fix 'Internal: no symbol found' for OpenMP aligned and linear clause.

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan accepted this revision.
kiranchandramohan added inline comments.
This revision is now accepted and ready to land.


================
Comment at: flang/lib/Semantics/resolve-directives.cpp:288
+    }
+    return true;
+  }
----------------
sameeranjoshi wrote:
> kiranchandramohan wrote:
> > Can this be false here?
> Keeping it for consistency sake with the convention followed in the file.
> Just asking if you know is there some reason to use some specific boolean value?
See the following links for the general answer. Basically the walk wont proceed to the nested components and will not call Post if false is returned.

https://github.com/llvm/llvm-project/blob/32897c05ab6ba90c3496270046aa5664b37f6557/flang/include/flang/Parser/parse-tree-visitor.h#L23

https://github.com/llvm/llvm-project/blob/32897c05ab6ba90c3496270046aa5664b37f6557/flang/include/flang/Parser/parse-tree-visitor.h#L178


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90538/new/

https://reviews.llvm.org/D90538