[PATCH] D90554: [CostModel] remove cost-kind predicate for intrinsics in basic TTI implementation

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 3 05:26:09 PST 2020


spatel added a comment.

In D90554#2370638 <https://reviews.llvm.org/D90554#2370638>, @samparker wrote:

>   Cost += 2 * thisT()->getCmpSelInstrCost(
>                   BinaryOperator::ICmp, OverflowTy, OverflowTy,
>                   CmpInst::BAD_ICMP_PREDICATE, CostKind);
>
> It looks like this second ICmp should be a select/

Nice catch...and wow, this is even worse than I imagined. :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90554/new/

https://reviews.llvm.org/D90554



More information about the llvm-commits mailing list