[PATCH] D90554: [CostModel] remove cost-kind predicate for intrinsics in basic TTI implementation

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 3 01:09:16 PST 2020


samparker added a comment.

  Cost += 2 * thisT()->getCmpSelInstrCost(
                  BinaryOperator::ICmp, OverflowTy, OverflowTy,
                  CmpInst::BAD_ICMP_PREDICATE, CostKind);

It looks like this second ICmp should be a select/

> Do we need to fix that before trying this patch?

I think it would be wise, just returning the scalarization cost for non-vector targets should get us in the right ball park.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90554/new/

https://reviews.llvm.org/D90554



More information about the llvm-commits mailing list