[PATCH] D90608: [WebAssembly] Implement ref.null

Mon Nov 2 13:49:03 PST 2020

tlively added a comment.

In D90608#2369392 <https://reviews.llvm.org/D90608#2369392>, @sbc100 wrote:

> In D90608#2369338 <https://reviews.llvm.org/D90608#2369338>, @tlively wrote:
>
>> In D90608#2369305 <https://reviews.llvm.org/D90608#2369305>, @sbc100 wrote:
>>
>>> lgtm.   In a project that primarily deals with C/C++ code I find "heap time" a little confusing because it makes me think of the malloc heap used by C/C++.   Why not "managed" or something like that to avoid ambiguity?   I guess that is being discussed in the spec and we should probably just follow their lead.
>>
>> I do think that matching the upstream spec "heap type" terminology is important, even if it's a little confusing in a C++ context.
>
> Do you think that upstream term "heap type" is reasonable, given the pre-existing alternate meaning of heap that already exists in the unmanaged world?

I've gotten used to that name, so I don't personally have any problems with it. I definitely see the potential for confusion, though. I hope it won't be too bad in practice because it will usually be clear from context whether "heap type" means a WebAssembly heap type or if it means something to do with the C++ heap.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90608/new/

https://reviews.llvm.org/D90608