[PATCH] D90608: [WebAssembly] Implement ref.null

Mon Nov 2 13:07:04 PST 2020

sbc100 added a comment.

In D90608#2369338 <https://reviews.llvm.org/D90608#2369338>, @tlively wrote:

> In D90608#2369305 <https://reviews.llvm.org/D90608#2369305>, @sbc100 wrote:
>
>> lgtm.   In a project that primarily deals with C/C++ code I find "heap time" a little confusing because it makes me think of the malloc heap used by C/C++.   Why not "managed" or something like that to avoid ambiguity?   I guess that is being discussed in the spec and we should probably just follow their lead.
>
> I do think that matching the upstream spec "heap type" terminology is important, even if it's a little confusing in a C++ context.

Do you think that upstream term "heap type" is reasonable, given the pre-existing alternate meaning of heap that already exists in the unmanaged world?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90608/new/

https://reviews.llvm.org/D90608