[PATCH] D90527: [GlobalISel] ComputeKnownBits - minimum leading/trailing zero bits in shifts (PR44526)

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon planned changes to this revision.
RKSimon added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/GISelKnownBits.cpp:388
   case TargetOpcode::G_SHL: {
     KnownBits RHSKnown;
+    computeKnownBitsImpl(MI.getOperand(1).getReg(), Known, DemandedElts,
----------------
arsenm wrote:
> I thought there was a move towards moving the shared implementation of these into KnownBits::. Is there a reason this needs to be repeated here?
No reason - I'll refactor the SelectionDAG version to do that and then update this to use it as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90527/new/

https://reviews.llvm.org/D90527