[PATCH] D90281: [FileCheck] Report missing prefixes when more than one is provided.

Mircea Trofin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 2 08:54:33 PST 2020


mtrofin marked 4 inline comments as done.
mtrofin added a comment.

In D90281#2367724 <https://reviews.llvm.org/D90281#2367724>, @jhenderson wrote:

> The documentation wasn't updated. Please do that.

Sorry I missed that - please see https://reviews.llvm.org/D90621



================
Comment at: llvm/test/FileCheck/allow-unused-prefixes.txt:1
+; RUN: not FileCheck --allow-unused-prefixes=false --check-prefixes=P1,P2 --input-file %S/Inputs/one-check.txt %S/Inputs/one-check.txt 2>&1 | FileCheck --check-prefix=MISSING-ONE %s
+; RUN: not FileCheck --allow-unused-prefixes=false --check-prefixes=P1,P2,P3 --input-file %S/Inputs/one-check.txt %S/Inputs/one-check.txt 2>&1 | FileCheck --check-prefix=MISSING-MORE %s
----------------
jhenderson wrote:
> Should this test be using `%ProtectFileCheckOutput`?
Not sure why, we're not setting env variables, or am I missing something?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90281/new/

https://reviews.llvm.org/D90281



More information about the llvm-commits mailing list