[PATCH] D90281: [FileCheck] Report missing prefixes when more than one is provided.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

The documentation wasn't updated. Please do that.



================
Comment at: llvm/test/FileCheck/Inputs/one-check.txt:3
+; P1: hello
\ No newline at end of file

----------------
Needs new line at EOF.


================
Comment at: llvm/test/FileCheck/allow-unused-prefixes.txt:1
+; RUN: not FileCheck --allow-unused-prefixes=false --check-prefixes=P1,P2 --input-file %S/Inputs/one-check.txt %S/Inputs/one-check.txt 2>&1 | FileCheck --check-prefix=MISSING-ONE %s
+; RUN: not FileCheck --allow-unused-prefixes=false --check-prefixes=P1,P2,P3 --input-file %S/Inputs/one-check.txt %S/Inputs/one-check.txt 2>&1 | FileCheck --check-prefix=MISSING-MORE %s
----------------
Should this test be using `%ProtectFileCheckOutput`?


================
Comment at: llvm/test/FileCheck/allow-unused-prefixes.txt:5-6
+
+; Note: the default will be changed to 'false', at which time this run line
+; should be changed accordingly.
+; RUN: FileCheck --check-prefixes=P1,P2 --input-file %S/Inputs/one-check.txt %S/Inputs/one-check.txt 
----------------
I try to encourage using double comment markers for real comments as opposed to lit directive markers, e.g. `;;` here.


================
Comment at: llvm/test/FileCheck/allow-unused-prefixes.txt:6
+; P1: hello
\ No newline at end of file

----------------
grimar wrote:
> No EOL.
This comment wasn't addressed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90281/new/

https://reviews.llvm.org/D90281