[PATCH] D89956: [AArch64] Redundant masks in downcast long multiply

Nicholas Guy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 2 08:30:56 PST 2020


NickGuy updated this revision to Diff 302291.
NickGuy added a comment.

> This pattern isn't needed I don't think

Removed

> but I would remove the whitespace and maybe reorder them.

Done

> Can you add a commuted test too

Added, the patterns do indeed match


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89956/new/

https://reviews.llvm.org/D89956

Files:
  llvm/lib/Target/AArch64/AArch64InstrInfo.td
  llvm/test/CodeGen/AArch64/aarch64-mull-masks.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D89956.302291.patch
Type: text/x-patch
Size: 3405 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201102/d6bb7d9e/attachment.bin>


More information about the llvm-commits mailing list