[PATCH] D90104: [LoopUnroll] Duplicate noalias metadata

[Jeroen Dobbelaere via Phabricator via llvm-commits]

jeroen.dobbelaere added a comment.

In D90104#2366355 <https://reviews.llvm.org/D90104#2366355>, @nikic wrote:

> @jeroen.dobbelaere: Yeah, I'm aware of that. However, the full restrict patches are a large change that has stalled for a long time, so I think we need to address the miscomples in a simple way in the meantime. I was also wondering if it might not make sense to split up the full restrict patches in a way that addresses individual problems without having to land the full machinery in one go. For example, by first introducing the noalias.decl function only, which is I believe the only part that's relevant for this particular problem.

I was hoping to be further in the review process by now.. but getting somebody to review/help reviewing the documentation patch already seems to be hard :(

Next week, I can put some effort into prepare a patch with the 'llvm.noalias.decl', together with the necessary cloning for loop unroll.
That should help you, by fixing this problem. It should also help the full restrict patches, by already incorporating part of it in the main llvm.

Maybe this is something we can discuss tomorrow in the llvm alias analysis technical call (Nov 3, 11am Mountain View Time) ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90104/new/

https://reviews.llvm.org/D90104