[PATCH] D88380: [VPlan] Extend VPValue to also model sub- & 'virtual' values.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

I went ahead and also implemented an alternative approach that is along the lines of the first iteration, using VPMultiDef. Instead of extending VPValue it introduces a new VPDef class that mirrors VPuser but for defined values. This means VPValue and other parts end up being simpler, at the cost that VPValues cannot be dyn_casted to recipes directly. Instead, you have to get the VPDef for a VPValue first and cast that to a recipe. Overall this approach seems a bit simpler than making VPValue more complicated as in the this series.

The interesting patches are D90558 <https://reviews.llvm.org/D90558>, D90564 <https://reviews.llvm.org/D90564>, D90562 <https://reviews.llvm.org/D90562> and D90565 <https://reviews.llvm.org/D90565> (which changes VPInstruction to using VPDef and gives an idea into what changes are required to operate on VPDef).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88380/new/

https://reviews.llvm.org/D88380