[PATCH] D90505: [AMDGPU] Improve FLAT scratch detection

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.h:517
   static bool isFLATScratch(const MachineInstr &MI) {
-    return isSegmentSpecificFLAT(MI);
   }
----------------
rampitec wrote:
> arsenm wrote:
> > What's wrong with another bit? Don't we already have it for global?
> We do not have it for global, otherwise I would just check it is unset.
> 
> I just see that we may soon exhaust the bitfield width.
We are actually using 56 bits out of 64. If I would use a bit for every single feature in every singe GPU we would go over the roof a long time ago (we actually did, so I had to remove some of the bits and use some non-obvious ways to replace it).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90505/new/

https://reviews.llvm.org/D90505