[PATCH] D90505: [AMDGPU] Improve FLAT scratch detection

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 30 15:52:11 PDT 2020


rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.h:517
   static bool isFLATScratch(const MachineInstr &MI) {
-    return isSegmentSpecificFLAT(MI);
   }
----------------
arsenm wrote:
> What's wrong with another bit? Don't we already have it for global?
We do not have it for global, otherwise I would just check it is unset.

I just see that we may soon exhaust the bitfield width.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90505/new/

https://reviews.llvm.org/D90505



More information about the llvm-commits mailing list