[PATCH] D89142: llvmbuildectomy

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added a comment.
Herald added a subscriber: awarzynski.

> - An upside of current approach is that a third-part system can run cmake independently to read the config files

Sound like the intended use case for https://cmake.org/cmake/help/latest/manual/cmake-server.7.html

> - I wanted to keep the change relatively minimal. So I'd rather do that in another commit

Since it's rewriting each LLVMBuild.txt, I wouldn't call it minimal. It may however, it reduce risks by keeping the solutions similar to each other, but also also reduces the benefit. That is, what is the advantage of replacing scripts written in Python by the same scripts rewritten in CMake? Practically, we still need Python for llvm-lit, extract_symbols.py, libc (gen_hdr.py), libcxxabi, compiler-rt (gen_dynamic_list.py), ...

I see the biggest disadvantage of LLVMBuild that one has to redundantly specify library dependencies that must be kept consistent and other subprojects (such as clang) don't even use. This approach doesn't fix that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89142/new/

https://reviews.llvm.org/D89142