[PATCH] D89142: llvmbuildectomy

[serge via Phabricator via llvm-commits]

serge-sans-paille added a comment.

In D89142#2343416 <https://reviews.llvm.org/D89142#2343416>, @Meinersbur wrote:

> Do we really need a `LLVMBuild.cmake` for every component? I hoped it would be possible to derive that information from CMake's dependency graph (which would avoid them being out-of-sync). If it's not feasible to get that information from CMake, why not use add_llvm_library in the CMakeLists.txt to pass that information?

That sounds feasible, but:

- An upside of current approach is that a third-part system can run cmake independently to read the config files
- I wanted to keep the change relatively minimal. So I'd rather do that in another commit



================
Comment at: llvm/cmake/modules/LLVM-Build.cmake:17
+#
+function(LLVMBuildComponent)
+
----------------
Meinersbur wrote:
> Even if already covered in `LLVMBuild.rst`, could you document which arguments are accepted here as well?
I started doing that, but felt it's ultra-redundant. I'll reference the original doc to avoid duplication.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89142/new/

https://reviews.llvm.org/D89142