[PATCH] D83655: [AsmPrinter] Split up .gcc_except_table
Rahman Lavaee via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 30 22:13:11 PDT 2020
rahmanl added a comment.
In D83655#2366091 <https://reviews.llvm.org/D83655#2366091>, @jrtc27 wrote:
> I wonder if it'd be nicer to push this logic into getLSDASection by passing an (optional?) Function given that's where the normal LSDASection gets created? Having the check for ELF here seems to indicate that the logic isn't quite in the right place and belongs in the MCOFI subclass.
I agree with @jrtc27 here. How about we implement this like `MCObjectFileInfo::getStackSizeSection(const MCSection&)` or `MCObjectFileInfo::getBBAddrMapSection(const MCSection&)`. The intended logic seems quite similar.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83655/new/
https://reviews.llvm.org/D83655
More information about the llvm-commits
mailing list