[PATCH] D83655: [AsmPrinter] Split up .gcc_except_table
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 30 18:49:20 PDT 2020
MaskRay marked an inline comment as done.
MaskRay added inline comments.
================
Comment at: llvm/lib/CodeGen/AsmPrinter/EHStreamer.cpp:469
+ const MCSymbolELF *LinkedToSym = nullptr;
+ unsigned Flags = ELF::SHF_ALLOC;
+ StringRef Group;
----------------
jrtc27 wrote:
> Should this instead inherit the (base) flags from LSDASection? For CHERI we have to add SHF_WRITE (we make it a relro section) so it'd be nice to inherit that automatically here rather than needing to have the logic duplicated between here and initELFMCObjectFileInfo.
Changed to the base flags to make CHERI convenient.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83655/new/
https://reviews.llvm.org/D83655
More information about the llvm-commits
mailing list