[PATCH] D90249: enable memoryssa for loopsink in new passmanager, expand loopsink testing and fix exposed bug in LICM

Jamie Schmeiser via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 30 10:50:36 PDT 2020


jamieschmeiser updated this revision to Diff 301954.
jamieschmeiser added a comment.

As requested, I have split the refactoring of the SinkAndHoistLICMFlags
into a separate PR and made this PR a child of that.

In answer to the review question, the intention is not to make the 2
passes different, but rather to advance the new pass manager version
to use memoryssa.  It has been observed that LoopSinking in a new
pass manager pipeline can take significant amounts of compile time
for some cases which is mitigated by using memoryssa.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90249/new/

https://reviews.llvm.org/D90249

Files:
  llvm/lib/Transforms/Scalar/LICM.cpp
  llvm/lib/Transforms/Scalar/LoopSink.cpp
  llvm/test/Transforms/LICM/loopsink-pr38462.ll
  llvm/test/Transforms/LICM/loopsink-pr39570.ll
  llvm/test/Transforms/LICM/loopsink-pr39695.ll
  llvm/test/Transforms/LICM/loopsink.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D90249.301954.patch
Type: text/x-patch
Size: 12296 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201030/680f987e/attachment-0001.bin>


More information about the llvm-commits mailing list