[PATCH] D90249: enable memoryssa for loopsink in new passmanager, expand loopsink testing and fix exposed bug in LICM
Alina Sbirlea via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 29 18:37:27 PDT 2020
asbirlea added a comment.
- Could you separate the SinkHoistFlag refactoring into an NFC?
- Could you clang-format and fix lints?
- LICM changes look good. AFAICT the MSSA changes in LoopSink are accurate, but it may need more testing than the existing unit tests.
- Why do you want the legacy pass manager to use the AST and the new pass manager MSSA?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90249/new/
https://reviews.llvm.org/D90249
More information about the llvm-commits
mailing list