[PATCH] D89761: Split out llvm/Support/FileSystem/UniqueID.h and clang/Basic/FileEntry.h, NFC

[Duncan P. N. Exon Smith via Phabricator via llvm-commits]

dexonsmith added inline comments.


================
Comment at: llvm/include/llvm/Support/FileSystem/UniqueID.h:36
+  bool operator<(const UniqueID &Other) const {
+    return std::tie(Device, File) < std::tie(Other.Device, Other.File);
+  }
----------------
rnk wrote:
> FYI std::tie is pretty expensive to compile, unfortunately. You also might technically need to include some STL header for it here.
I just sent you https://reviews.llvm.org/D90471 to remove `std::tie`. (Already fixed the includes in 44d65efd95b353eeb26440ad2ef9f3bd05f5a927, not sure how/why it worked without them locally.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89761/new/

https://reviews.llvm.org/D89761