[PATCH] D89761: Split out llvm/Support/FileSystem/UniqueID.h and clang/Basic/FileEntry.h, NFC
Reid Kleckner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 29 15:50:15 PDT 2020
rnk added a comment.
I just saw this in passing. Thanks a lot, I had noticed that Filesystem.h is super expensive.
================
Comment at: llvm/include/llvm/Support/FileSystem/UniqueID.h:36
+ bool operator<(const UniqueID &Other) const {
+ return std::tie(Device, File) < std::tie(Other.Device, Other.File);
+ }
----------------
FYI std::tie is pretty expensive to compile, unfortunately. You also might technically need to include some STL header for it here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89761/new/
https://reviews.llvm.org/D89761
More information about the llvm-commits
mailing list