[PATCH] D90371: [DSE] Improve partial overlap detection

[Evgeniy via Phabricator via llvm-commits]

ebrevnov added a comment.

In D90371#2363420 <https://reviews.llvm.org/D90371#2363420>, @asbirlea wrote:

> This LGTM.
> I'd like to understand better what you mean by not calling partialOverwrite. If the functionality in that call would be included in the isOverwrite call, note that there are call-paths that would do more work than they do now, and I thought there was a previous refactoring done to avoid this.

As of today isPartialOverwrite does two things. 1) Clarifies OW_MaybePartial returned by isOverwrite  2) Takes some actions if EnablePartialOverwriteTracking is true and accesses do overwrite. My suggestion to move part 1) into isOverwrite  and keep second part inside isPartialOverwrite (and rename isPartialOverwrite).

> I may be mis-understanding though, so feel free to send the additional changes and we can discuss on those.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90371/new/

https://reviews.llvm.org/D90371