[PATCH] D90371: [DSE] Improve partial overlap detection
    Alina Sbirlea via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Thu Oct 29 16:37:42 PDT 2020
    
    
  
asbirlea accepted this revision.
asbirlea added a comment.
This LGTM.
I'd like to understand better what you mean by not calling partialOverwrite. If the functionality in that call would be included in the isOverwrite call, note that there are call-paths that would do more work than they do now, and I thought there was a previous refactoring done to avoid this.
I may be mis-understanding though, so feel free to send the additional changes and we can discuss on those.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90371/new/
https://reviews.llvm.org/D90371
    
    
More information about the llvm-commits
mailing list