[PATCH] D89218: [DebugInfo] Support for DW_TAG_generic_subrange

[Alok Kumar Sharma via Phabricator via llvm-commits]

alok added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfExpression.cpp:546
+      assert(!isRegisterLocation());
+      emitSigned(Op->getArg(0));
+      break;
----------------
markus wrote:
> Question: aren't we missing a `emitOp(dwarf::DW_OP_consts)` here? AFAICT `emitSigned` is not similar to `emitConstu` in that sense (i.e. the former does not do `emitOp` internally).
Thanks for pointing this out. You are correct this is missed. I plan to commit the correction. I hope this would not require separate review ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89218/new/

https://reviews.llvm.org/D89218