[PATCH] D89218: [DebugInfo] Support for DW_TAG_generic_subrange
Markus Lavin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 29 02:50:36 PDT 2020
markus added inline comments.
================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfExpression.cpp:546
+ assert(!isRegisterLocation());
+ emitSigned(Op->getArg(0));
+ break;
----------------
Question: aren't we missing a `emitOp(dwarf::DW_OP_consts)` here? AFAICT `emitSigned` is not similar to `emitConstu` in that sense (i.e. the former does not do `emitOp` internally).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89218/new/
https://reviews.llvm.org/D89218
More information about the llvm-commits
mailing list