[PATCH] D88060: [GISel]: Few InsertVecElt combines

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:2479
+  Register UndefReg;
+  auto GetUndef = [&]() {
+    if (UndefReg.isValid())
----------------
aditya_nandakumar wrote:
> foad wrote:
> > Nit: could inline this into its only caller.
> This attempts to just cache UNDEFs without relying on CSE mechanism.
I'm saying the function (lambda) GetUndef is only caled once, so there's no real need for it to be a separate function.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88060/new/

https://reviews.llvm.org/D88060