[PATCH] D90307: [AMDGPU] Fix double space in disassembly of ds_gws_sema_* with gds

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 28 11:42:59 PDT 2020


rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUInstPrinter.cpp:142
+    if (OpNo == 0)
+      O << ' ';
   }
----------------
Are you sure it didn't add an extra space in some other instructions? Are there any other instructions where offset can be the first operand?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90307/new/

https://reviews.llvm.org/D90307



More information about the llvm-commits mailing list