[PATCH] D90307: [AMDGPU] Fix double space in disassembly of ds_gws_sema_* with gds

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 28 08:11:51 PDT 2020


foad marked an inline comment as done.
foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/DSInstructions.td:333
 : DS_GWS<opName,
-  (ins offset:$offset, gds:$gds), "$offset gds"> {
+  (ins offset:$offset, gds:$gds), "${offset}gds"> {
   let hasSideEffects = 1;
----------------
arsenm wrote:
> Why is there a $gds operand here if it's not used for printing?
There's already a TODO for that: https://github.com/llvm/llvm-project/blob/5febc535c4f8e278124cdeb88a4a82d99016944c/llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp#L2501


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90307/new/

https://reviews.llvm.org/D90307



More information about the llvm-commits mailing list