[PATCH] D90281: [FileCheck] Report missing prefixes when more than one is provided.

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 28 11:00:51 PDT 2020


dblaikie added a comment.

+1 to what other folks have said here, would be good to have a sample of the sort of tests that fail with this functionality - do we have lots of these either programmatically or otherwise symmetrically structured tests (some might be manually written but still benefit from a consistent pattern that may include unused check prefixes)? Or is it only a handful of places that would need to be fixed. But in any case, adding the flag upstream then committing changes incrementally to the tests or test-generators that need them, then eventually flipping the switch would probably be the way forward (unless we're talking like a huge % of all tests that need this flag added, then maybe it's not worthwhile/might need to look at more samples to discuss what the right tradeoffs/techniques are)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90281/new/

https://reviews.llvm.org/D90281



More information about the llvm-commits mailing list