[PATCH] D90281: [FileCheck] Report missing prefixes when more than one is provided.

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 28 10:55:36 PDT 2020


jdoerfert added a comment.

> The remaining question is how to stage this. I think there are 2 broad ways to do it:
>
> 1. we enable it by default, and this patch goes and patches all failing tests with an opt-out.
> 2. we start with it disabled. Then, people opt in explicitly.

I think 1) is better but we need to address the 1500 failures. ~99 will go away when I patch the attributor tests, so I would suggest we first add the opt-out flag and start using it. Then we can keep track of problems in this commit and we don't have to touch 1500 files here. We should also look for patterns and write a script ;)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90281/new/

https://reviews.llvm.org/D90281



More information about the llvm-commits mailing list