[PATCH] D90195: [GWP-ASan] Abstract the thread local variables access

[Kostya Kortchinsky via Phabricator via llvm-commits]

cryptoad added inline comments.


================
Comment at: compiler-rt/lib/gwp_asan/platform_specific/guarded_pool_allocator_tls.h:45
+inline ThreadLocalPackedVariables *getThreadLocals() {
+  alignas(8) static GWP_ASAN_TLS_INITIAL_EXEC ThreadLocalPackedVariables Locals;
+  return &Locals;
----------------
hctim wrote:
> Any ideas why clang-tidy is reporting this?
Maybe because it doesn't have stdint.h in this file so it doesn't know it's constant.


================
Comment at: compiler-rt/lib/gwp_asan/platform_specific/utilities_posix.cpp:27
   abort();
-#else // __BIONIC__
+#else  // __BIONIC__
   fprintf(stderr, "%s", Message);
----------------
hctim wrote:
> using old clang-format instead of new?
Actually using the tot one :/
I think it's aligning this comment with the #endif one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90195/new/

https://reviews.llvm.org/D90195