[PATCH] D90195: [GWP-ASan] Abstract the thread local variables access

[Mitch Phillips via Phabricator via llvm-commits]

hctim accepted this revision.
hctim added a comment.

LGTM w/ nits.



================
Comment at: compiler-rt/lib/gwp_asan/platform_specific/guarded_pool_allocator_tls.h:45
+inline ThreadLocalPackedVariables *getThreadLocals() {
+  alignas(8) static GWP_ASAN_TLS_INITIAL_EXEC ThreadLocalPackedVariables Locals;
+  return &Locals;
----------------
Any ideas why clang-tidy is reporting this?


================
Comment at: compiler-rt/lib/gwp_asan/platform_specific/utilities_posix.cpp:27
   abort();
-#else // __BIONIC__
+#else  // __BIONIC__
   fprintf(stderr, "%s", Message);
----------------
using old clang-format instead of new?


================
Comment at: compiler-rt/lib/gwp_asan/utilities.cpp:40
     AlignmentStrategy::BIONIC;
-#else // __BIONIC__
+#else  // __BIONIC__
 static constexpr AlignmentStrategy PlatformDefaultAlignment =
----------------
same thing - need new clang-format?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90195/new/

https://reviews.llvm.org/D90195