[PATCH] D89995: Make the post-commit review expectations more explicit with respect to revert
Dmitri Gribenko via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 28 03:30:04 PDT 2020
gribozavr2 added a comment.
Generally, I think this patch reflects the existing expectation in the community, when the post-commit feedback is provided promptly.
Right now the suggested change is worded too strongly: it says that the author is responsible to revert promptly in response to any revert request, no matter the age of the commit. Some old commits can be easily reverted (for example, one-line changes of defaults), some can't be (I'd love if if we could undo that commit in Clang that makes Expr a subclass of Stmt, but asking to revert that right now would be unproductive).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89995/new/
https://reviews.llvm.org/D89995
More information about the llvm-commits
mailing list