[PATCH] D90281: [FileCheck] Report missing prefixes when more than one is provided.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

+1 to the principle of this change - I wouldn't be surprised to see typos in at least some of the failing tests meaning that the incorrect check prefix isn't noticed. +1 also to an option to disable the check for the suggested reasons (I don't think I've personally got a use-case for it, but it seems like there are reasonable ones) - I'd be inclined to put the option in independently of the change that actually uses it, so that the tests can be updated independently, and gradually.



================
Comment at: llvm/lib/FileCheck/FileCheck.cpp:1830
+  StringSet<> PrefixesNotFound;
+  for (auto CP : Req.CheckPrefixes)
+    PrefixesNotFound.insert(CP);
----------------
I'd prefer no `auto` here - what's the type of `CP`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90281/new/

https://reviews.llvm.org/D90281