[PATCH] D90281: [FileCheck] Report missing prefixes when more than one is provided.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 28 00:45:04 PDT 2020


grimar added inline comments.


================
Comment at: llvm/lib/FileCheck/FileCheck.cpp:26
 #include <tuple>
+#include <unordered_set>
 #include <utility>
----------------
Seems unused?


================
Comment at: llvm/lib/FileCheck/FileCheck.cpp:1942
+    bool First = true;
+    for (auto P : PrefixesNotFound.keys()) {
+      if (!First)
----------------
`StringMap` iteration order is not guaranteed to be deterministic. I think
some different container like `MapVector` probably should be used here instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90281/new/

https://reviews.llvm.org/D90281



More information about the llvm-commits mailing list