[PATCH] D79141: [RISCV] Better Split Stack Pointer Adjustment for RVC
Sam Elliott via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 27 14:32:29 PDT 2020
lenary added inline comments.
================
Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.h:60
- // Get the first stack adjustment amount for SplitSPAdjust.
- // Return 0 if we don't want to to split the SP adjustment in prologue and
- // epilogue.
- uint64_t getFirstSPAdjustAmount(const MachineFunction &MF) const;
+ /**
+ * Returns if we want to adjust the SP in two adjustments in the prolog and
----------------
jrtc27 wrote:
> lenary wrote:
> > asb wrote:
> > > Should use a C++ style comment
> > Actually I want to keep this as a doc comment, given it's in the header.
> So `///` then?
Ah, I didn't realise LLVM had a preference, because there are both styles in the repository.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79141/new/
https://reviews.llvm.org/D79141
More information about the llvm-commits
mailing list