[PATCH] D79141: [RISCV] Better Split Stack Pointer Adjustment for RVC

Sam Elliott via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 27 14:31:43 PDT 2020


lenary updated this revision to Diff 301103.
lenary added a comment.

Fixing comment style.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79141/new/

https://reviews.llvm.org/D79141

Files:
  llvm/lib/Target/RISCV/RISCVFrameLowering.h


Index: llvm/lib/Target/RISCV/RISCVFrameLowering.h
===================================================================
--- llvm/lib/Target/RISCV/RISCVFrameLowering.h
+++ llvm/lib/Target/RISCV/RISCVFrameLowering.h
@@ -57,19 +57,17 @@
                               MutableArrayRef<CalleeSavedInfo> CSI,
                               const TargetRegisterInfo *TRI) const override;
 
-  /**
-   * Returns whether the stack pointer (SP) should be adjusted in two
-   * adjustments in the prologue and epilogue ("split"), or only adjusted once.
-   *
-   * Splitting the SP adjustment can result in better code size.
-   *
-   * The result will be `None` if the SP adjustment should not be split, or an
-   * Optional containing the first adjustment amount if the adjustment should be
-   * split.
-   *
-   * The first SP adjustment will never be more than the function's StackSize,
-   * so that the second SP adjustment is monotinic.
-   */
+  /// Returns whether the stack pointer (SP) should be adjusted in two
+  /// adjustments in the prologue and epilogue ("split"), or only adjusted once.
+  ///
+  /// Splitting the SP adjustment can result in better code size.
+  ///
+  /// The result will be `None` if the SP adjustment should not be split, or an
+  /// Optional containing the first adjustment amount if the adjustment should be
+  /// split.
+  ///
+  /// The first SP adjustment will never be more than the function's StackSize,
+  /// so that the second SP adjustment is monotinic.
   Optional<uint64_t>
   getFirstSPAdjustmentAmount(const MachineFunction &MF) const;
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D79141.301103.patch
Type: text/x-patch
Size: 1582 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201027/403c686b/attachment.bin>


More information about the llvm-commits mailing list