[PATCH] D88962: [SVE] Add support for scalable vectors in vectorize_width loop attribute

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

In D88962#2354863 <https://reviews.llvm.org/D88962#2354863>, @sdesmalen wrote:

> LGTM with nits addressed. @fhahn are you happy with the changes?

LG in general, thanks for the updates.



================
Comment at: llvm/docs/LangRef.rst:5911
 
-Note that setting ``llvm.loop.vectorize.width`` to 1 disables
-vectorization of the loop. If ``llvm.loop.vectorize.width`` is set to
-0 or if the loop does not have this metadata the width will be
-determined automatically.
+where ``i32 4`` specifies the vector width and ``i32 1`` indicates if the
+vectorization factor is scalable, meaning that the loop-vectorizer should use
----------------
sdesmalen wrote:
> nit:
>   s/vector width/minimum known vector width/
>   s/and `i32 1`/and the non-zero value `i1 true`/
nit: I'd start with saying that the first value of the tuple is the vector width and the second value indicates whether the vectorization factor is scalable and then follow with the example saying this means min vector width of 4 & scalable vectorization


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88962/new/

https://reviews.llvm.org/D88962