[PATCH] D88962: [SVE] Add support for scalable vectors in vectorize_width loop attribute

[David Sherwood via Phabricator via llvm-commits]

david-arm added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorizationLegality.cpp:61
+  unsigned IntVal;
+  unsigned IsScalable = 0;
+
----------------
sdesmalen wrote:
> nit: `s/unsigned IsScalable = 0;/bool IsScalable = false;/`
Given that it is possible to specify this as "i32" type, even if the docs says "i1", are you saying that it's fine to specify the vector width as "i32 4, i32 345", for example? In this example with your changes "i32 345" will be treated as scalable = true. This is the reason I had this value as i32, in order to capture odd cases.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88962/new/

https://reviews.llvm.org/D88962