[PATCH] D90070: [CostModel] Add optional VecPred argument to getCmpSelInstrCost.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.





================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:702
+        VecPred = CurrentPred;
+    }
+    // Check if we have a compare/select chain that can be lowered using CMxx &
----------------
RKSimon wrote:
> Would it make sense to do this in TargetTransformInfo::getCmpSelInstrCost? Most platforms are likely to do something similar.
I think that makes sense, but unfortunately it seems like `TargetTransformInfo::getCmpSelInstrCost` is not called for at least `-analyze -costmodel`, because it uses `TargetTransformInfoImplCRTPBase::getUserCost`, which delegates directly to the target-specific `getCmpSelInstrCost`. Not sure if there's a convenient way to work around that?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90070/new/

https://reviews.llvm.org/D90070