[PATCH] D90070: [CostModel] Add optional VecPred argument to getCmpSelInstrCost.

[Florian Hahn via Phabricator via llvm-commits]

fhahn updated this revision to Diff 300664.
fhahn marked an inline comment as done.
fhahn added a comment.



In D90070#2352567 <https://reviews.llvm.org/D90070#2352567>, @dmgreen wrote:

> AArch64 costs sound OK, especially if we can fix NE codegen to be more likely to be a single instruction.
>
> I would personally keep the args in (Opcode, Types, CondCode, CostKind, CtxI) order, to keep them more consistent with the other cost functions. Now that I look at them though I don't think they are as consistent as I believed they were!

I think having the CondCode after the types would make sense. One advantage of the current ordering is that we do not need to update all existing callers that pass in CtxI. That convenient initially, but there are not too many users of the function that would need updating. Happy to update to whatever order is preferred before landing the patch (threading things through properly everywhere is a bit of a pain, so I'd prefer updating once everyone is happy, to just do it once).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90070/new/

https://reviews.llvm.org/D90070

Files:
  llvm/include/llvm/Analysis/TargetTransformInfo.h
  llvm/include/llvm/Analysis/TargetTransformInfoImpl.h
  llvm/include/llvm/CodeGen/BasicTTIImpl.h
  llvm/lib/Analysis/TargetTransformInfo.cpp
  llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp
  llvm/lib/Target/AArch64/AArch64TargetTransformInfo.h
  llvm/lib/Target/ARM/ARMTargetTransformInfo.cpp
  llvm/lib/Target/ARM/ARMTargetTransformInfo.h
  llvm/lib/Target/Hexagon/HexagonTargetTransformInfo.cpp
  llvm/lib/Target/Hexagon/HexagonTargetTransformInfo.h
  llvm/lib/Target/PowerPC/PPCTargetTransformInfo.cpp
  llvm/lib/Target/PowerPC/PPCTargetTransformInfo.h
  llvm/lib/Target/SystemZ/SystemZTargetTransformInfo.cpp
  llvm/lib/Target/SystemZ/SystemZTargetTransformInfo.h
  llvm/lib/Target/X86/X86TargetTransformInfo.cpp
  llvm/lib/Target/X86/X86TargetTransformInfo.h
  llvm/test/Analysis/CostModel/AArch64/vector-select.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D90070.300664.patch
Type: text/x-patch
Size: 24859 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201026/28e90742/attachment.bin>