[PATCH] D88741: [SystemZ/z/OS] Add utility class for char set conversion.

[Eric Christopher via llvm-commits]

Seems reasonable to me.

-eric

On Sat, Oct 24, 2020 at 9:23 PM ThePhD via Phabricator <
reviews at reviews.llvm.org> wrote:

> ThePhD added a comment.
>
> Minor addition for this change; if this does go through, llvm-specific
> macros in C-like languages should expose the chosen name. I submitted a
> patch and a feature request to MSVC and GCC for their own
> implementation-specific macros as well:
>
> -
> https://developercommunity.visualstudio.com/content/idea/1160821/-compiler-feature-macro-for-narrow-literal-foo-enc.html
> - https://gcc.gnu.org/pipermail/gcc-patches/2020-October/555801.html
>
> It doesn't need to be synchronized with any other compiler's name or
> exposed feature: it just needs to exist. This allows folks interested in
> helping people write portable code that uses the execution character set
> preserve the invariants of their code by allowing them to inspect the name
> and act meaningfully for names they recognize.
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D88741/new/
>
> https://reviews.llvm.org/D88741
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201024/d0ff79b0/attachment.html>